[Types] Fix rebase bug in aggregate wireables #1152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I chose the wrong changes for these functions when rebasing the tuple2 code. With the aggregate_wireable_method decorator, they only need to implement the logic for when children are elaborated (the decorator calls the aggregate method if the has_elaborated_children check fails). This didn't trigger a CI bug because when unwire fails, it just raises a warning (e.g. driving an already driven value) that occurs silently in the passing tests. Adds a test to cover this case.
rsetaluri
approved these changes
Oct 11, 2022
rsetaluri
changed the title
rsetaluri
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I chose the wrong changes for these functions when rebasing the tuple2 code. With the aggregate_wireable_method decorator, they only need to implement the logic for when children are elaborated (the decorator calls the aggregate method if the has_elaborated_children check fails). This didn't trigger a CI bug because when unwire fails, it just raises a warning (e.g. driving an already driven value) that occurs silently in the passing tests. Adds a test to cover this case.